-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A paginator’s base_url ends with double slash when paginate_path is empty. #866
Comments
Hmm empty path should be an error anyway. |
I am pretty happy that it doesn’t throw an error 😉 Currently this lets me do Zola has no problem generating the the files exactly where I would expect them, so other than the double slash at the end I do not see a problem with supporting this use-case. |
That's fixed in |
Not currently on a machine where I can build Zola from source, but judging from the commit you kept support for the empty path and are now explicitly testing for the behaviour I am using. Many thanks for that! |
Yep, your usecase is a very valid one I didn't think ok. |
Bug Report
I was playing around with getting a simple content listing going, for this I did not want pagination to create a sub-directory. So having a number of pages in
/content/
I also created the following_index.md
there:This results in
paginator.base_url
beinghttp://127.0.0.1:1111//
when runningzola serve
. I would expect justhttp://127.0.0.1:1111/
.Environment
Zola version: 0.9.0
The text was updated successfully, but these errors were encountered: