Hack fix and new tests for body-shortcodes #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Up to you, we can do the cleanup mentioned in the other issue as I think I want to finish and upgrade the version of Tera in the next version. I'm going to publish the current master as 0.2.2 today or tomorrow so we're free to take time after that |
|
Awesome. I think this fix is worthwhile if you're doing a new release, and then we can take our time on doing the restructuring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is a total hack, but it fixes the issue described in #160, without massively restructuring the code.
The essential problem is that shortcodes really should be a "Gutenberg Flavored Markdown" extension but we don't get events that signal "start shortcode" and "end startcode" which would vastly simplify implementing the actual processing of shortcodes.
@reillysiemens, @fuginator, and I think this is a reasonable short term fix to include, but longer term (like maybe for 0.3.0?) the code should probably be restructured to make this way less hacky to implement.