Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): handle already existing path #815

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

riginding
Copy link
Contributor

This should fix the bug mentioned in #814 .

I wanted to write test for it but I had some problems testing the create_project_function.
I think to test this properly I would need to use dependency injection and pass at_least input to ask_url and ask_bool function. I wanted to ask first if this is the prefered way to do it before I start changing more of the code.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

@Keats
Copy link
Collaborator

Keats commented Oct 8, 2019

The easiest way to test that would be to extract the actual creation into an another function that takes the result of the questions so it can be tested easily

@Keats
Copy link
Collaborator

Keats commented Oct 24, 2019

@riginding ping

@riginding
Copy link
Contributor Author

riginding commented Oct 25, 2019

Sorry, for taking such a long time. I totally forgot that I opened this pull request.
I've now added the necessary tests.

@Keats
Copy link
Collaborator

Keats commented Oct 28, 2019

Perfect, thanks!

@Keats Keats merged commit 75ccfae into getzola:next Oct 28, 2019
Keats pushed a commit that referenced this pull request Feb 3, 2020
* fix(init):  handle already existing path

* chore: add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants