Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let toc is visable through Page & Section variables in templates #818

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

nottxy
Copy link
Contributor

@nottxy nottxy commented Oct 10, 2019

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Yes

Code changes

  • Are you doing the PR on the next branch?

Yes

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

Yes

@Keats
Copy link
Collaborator

Keats commented Oct 10, 2019

Is that specifically for #694 or did you need that yourself?

The PR itself looks good, although it might be worth it removing the current toc variable from page/section to avoid serializing it twice.

@nottxy
Copy link
Contributor Author

nottxy commented Oct 11, 2019

Yes, kind of some case like #694 .

It is better that the toc could be removed from page & section, but there would be a break change.

@Keats
Copy link
Collaborator

Keats commented Oct 11, 2019

It is better that the toc could be removed from page & section, but there would be a break change.

That's fine, next version is planned to have breaking changes.

@Keats Keats merged commit 77409a9 into getzola:next Oct 14, 2019
@Keats
Copy link
Collaborator

Keats commented Oct 14, 2019

Thanks!

Keats pushed a commit that referenced this pull request Oct 24, 2019
* Let toc is visable through Page & Section variables in templates

* Removed the current toc variable from page & section
Keats pushed a commit that referenced this pull request Feb 3, 2020
* Let toc is visable through Page & Section variables in templates

* Removed the current toc variable from page & section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants