Properly escape & in injected live-reload script tag
#825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"[…] `&` normally indicates the start of a character entity reference or numeric character reference; writing it as `&` […] allows `&` to be included in the content of an element or in the value of an attribute." From: https://en.wikipedia.org/wiki/HTML#Character_and_entity_references
|
Thanks! |
Keats
pushed a commit
that referenced
this pull request
Feb 3, 2020
"[…] `&` normally indicates the start of a character entity reference or numeric character reference; writing it as `&` […] allows `&` to be included in the content of an element or in the value of an attribute." From: https://en.wikipedia.org/wiki/HTML#Character_and_entity_references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unescaped Ampersands used as query string separators in an URL must be escaped when that URL is used as value for an HTML (or XML, for that matter) attribute.
From: https://en.wikipedia.org/wiki/HTML#Character_and_entity_references
And here's a screenshot (as seen in #824) in which the red coloring added by Firefox's source code viewer indicates an issue with the markup:
