Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title and body to alias page #830

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

spk
Copy link
Contributor

@spk spk commented Oct 27, 2019

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

  • Are you doing the PR on the next branch?

This ensure the redirect page have a title and a body with a link in case the browser does not handle refresh redirects

@Keats
Copy link
Collaborator

Keats commented Oct 28, 2019

Hmm why? Which browser does not support the http-equiv="refresh"?

@spk
Copy link
Contributor Author

spk commented Oct 28, 2019

With firefox this can be disabled with accessibility.blockautorefresh = true currently we have a blank page. A good practice is to have a title and body to show what we are trying to do and give more information to the user blocking auto refresh

@Keats
Copy link
Collaborator

Keats commented Oct 28, 2019

Ok, i'm guessing these don't need to be translated as it will be a very niche situation. Thanks!

@Keats Keats merged commit 83363d8 into getzola:next Oct 28, 2019
@spk spk deleted the fix-redirect-body branch October 28, 2019 19:16
Keats pushed a commit that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants