-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #844 duplicate entries in doc #845
fixes #844 duplicate entries in doc #845
Conversation
Hey, thanks for that but that list is actually generated by syntect automatically when rebuilding the syntaxes in https://github.com/getzola/zola/blob/master/components/config/examples/generate_sublime.rs#L30-L34 so it would need to be solved there |
Thanks @Keats , I'll check that. |
* generates syntaxes list, sorted and without duplicate
@Keats I've checked the code. The solution I came with is not what I really wanted, i.e it's a naive implementation which :
I wanted instead to merge the duplicate entries, i.e detect when two of more entries refer to the same languages, and merge their file_extensions, but then I had to fight a battle vs Rust compiler. My understanding of this language is quite limited for now (had to learn Rust to work on this PR) while the compiler can be quite annoying / strict. Examples online were not always relevant or clear enough. So if you have examples of clean solutions for this, I would be glad to update the PR. Otherwise feel free to do so or close it / accept it depending on the requirements :) |
* generates syntaxes list, sorted and with no duplicate * get rid of dependencies thanks to code review
* generates syntaxes list, sorted and with no duplicate * applied code review advices, to make better usage of api
Thanks! |
Thank you @Keats 😁, this was a great opportunity to start learning about rust. Maybe not my last contribution. |
I hope it isn't! |
fixes #844