Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple clean up of documentation. #849

Merged
merged 42 commits into from
Nov 26, 2019
Merged

Simple clean up of documentation. #849

merged 42 commits into from
Nov 26, 2019

Conversation

photong
Copy link
Contributor

@photong photong commented Nov 22, 2019

This is the first step of the documentation clean up.

@photong photong changed the title Simple clean up of "Getting Started" and "Content" sections. Simple clean up of documentation. Nov 22, 2019
Copy link
Collaborator

@Keats Keats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, thanks a lot!
I have a few comments on it but nothing major

@@ -50,7 +50,7 @@ The function returns a full URL to the resized image.

## Resize operations

The source for all examples is this 300 × 380 pixels image:
The source for all examples is this 300 pixel × 380 pixel image:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 300x380 pixels not more correct than 300 pixel x 380 pixel? No s on pixel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, "pixel" is an adjective. Similar to "3-meter-tall building" (not "3-meters-tall building"). I omitted "-" here because "300-pixel x 380-pixel image" is difficult to read.

@@ -118,7 +121,7 @@ The `resize_image()` can be used multiple times and/or in loops. It is designed

This can be used along with `assets` [page metadata](@/documentation/templates/pages-sections.md) to create picture galleries.
The `assets` variable holds paths to all assets in the directory of a page with resources
(see [assets colocation](@/documentation/content/overview.md#assets-colocation)): if you have files other than images you
(see [asset co-location](@/documentation/content/overview.md#asset-co-location)); if you have files other than images you
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both spelling are correct (at least according to Wikipedia: https://en.wikipedia.org/wiki/Colocation_centre) and not changing it means that links to it will still work.

Copy link
Contributor Author

@photong photong Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. There is also "collocation" (older word). Please see https://www.grammarphobia.com/blog/2013/08/collocation-colocation-co-location.html for a long discussion if interested. I just thought "co-location" is a bit easier to read (I think I fixed the links too). I'm ok with colocation, so please revert this change.


## Anchor insertion
It is possible to have Zola automatically insert anchor links next to the heading, as you can see on the site you are currently
reading if you hover a title.
It is possible to have Zola automatically insert anchor links next to the heading, as you can see on this site
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

site -> documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. "site your are currently reading" = "this documentation". Please make this change.


## Assets colocation
## Asset co-location
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, I'm not sure breaking the links is worth it if they are both correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Please revert.


```toml
```TOML
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are markers for the syntax highlighter, I don't think we want to change them as they usually work by matching the file extension.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't notice that "toml" will not show up in the output. Please revert.

@@ -1,24 +1,24 @@
+++
title = "CLI usage"
weight = 2
weight = 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not intended for the "next" branch. I'm reorganizing the documentation in a "docs-next' branch on my fork. I changed the weights to multiples of 10 in case I need to add new sections (for example, I added an "Overview" section to "Getting Started"). Please revert.

@Keats
Copy link
Collaborator

Keats commented Nov 26, 2019

Thanks, I'll push my changes directly after merging.

@Keats Keats merged commit 843c406 into getzola:next Nov 26, 2019
Keats pushed a commit that referenced this pull request Feb 3, 2020
* Update installation.md

* Update cli-usage.md

* Update installation.md

* Update directory-structure.md

* Update configuration.md

* Update overview.md

* Update section.md

* Update page.md

* Update section.md

* Update configuration.md

* Update page.md

* Update section.md

* Update page.md

* Update shortcodes.md

* Update linking.md

* Update table-of-contents.md

* Update syntax-highlighting.md

* Update taxonomies.md

* Update search.md

* Update sass.md

* Update index.md

* Update multilingual.md

* Update overview.md

* Update pages-sections.md

* Update pagination.md

* Update taxonomies.md

* Update rss.md

* Update sitemap.md

* Update robots.md

* Update 404.md

* Update archive.md

* Update overview.md

* Update installing-and-using-themes.md

* Update creating-a-theme.md

* Update netlify.md

* Update github-pages.md

* Update gitlab-pages.md

* Update index.md

* Update page.md

* Update section.md

* Updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants