Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section extra -> SitemapEntry #850

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Section extra -> SitemapEntry #850

merged 1 commit into from
Nov 26, 2019

Conversation

stanistan
Copy link
Contributor

@stanistan stanistan commented Nov 23, 2019 •
edited
Loading

General summary:

  • Fixes Sections in sitemaps don't get their [extra] #842
  • Section has parity with Page extra (using a tera::Map instead of std::collections::Map)
  • SitemapEntry gets passed the section.meta.extra
  • Added regression tests to make sure that the sitemap has the extra of the section
  • unrelated formatting changes are because I ran cargo fmt on the project
  • Question: There are some changes in modules structure (making sitemap pub) in order to make it easy to do a regression test there. Is there a better place for this?

Code changes

  • Are you doing the PR on the next branch?

@Keats Keats merged commit 8f669d3 into getzola:next Nov 26, 2019
@Keats
Copy link
Collaborator

Keats commented Nov 26, 2019

Question: There are some changes in modules structure (making sitemap pub) in order to make it easy to do a regression test there. Is there a better place for this?

In that specific case it's not super easy to test since you need a full library so it's fine making it public. This is an application after all, not a library.

Keats added a commit that referenced this pull request Jan 20, 2020
@photong @TjeuKayim
@Keats @stanistan
Docs next (#858)
d96ddc7 
* Update installation.md

* Update cli-usage.md

* Update installation.md

* Update directory-structure.md

* Update configuration.md

* Update overview.md

* Update section.md

* Update page.md

* Update section.md

* Update configuration.md

* Update page.md

* Update section.md

* Update page.md

* Update shortcodes.md

* Update linking.md

* Update table-of-contents.md

* Update syntax-highlighting.md

* Update taxonomies.md

* Update search.md

* Update sass.md

* Update index.md

* Update multilingual.md

* Update overview.md

* Update pages-sections.md

* Update pagination.md

* Update taxonomies.md

* Update rss.md

* Update sitemap.md

* Update robots.md

* Update 404.md

* Update archive.md

* Update overview.md

* Update installing-and-using-themes.md

* Update creating-a-theme.md

* Update netlify.md

* Update github-pages.md

* Update gitlab-pages.md

* Updates.

* Skip link checking for URL with prefix in config (#846)

* Fix some doc changes

* Section extra -> SitemapEntry (#850)

* Update deps

* Remove tutorial link.

* Update overview.md

* Update page.md

* Update section.md

* Update netlify.md

* Update overview.md

* Change some wording.

* Update overview.md

Co-authored-by: Tjeu Kayim <[email protected]>
Co-authored-by: Vincent Prouillet <[email protected]>
Co-authored-by: Stan Rozenraukh <[email protected]>
Keats pushed a commit that referenced this pull request Feb 3, 2020
@stanistan @Keats
Section extra -> SitemapEntry (#850)
a89b300
Keats added a commit that referenced this pull request Feb 3, 2020
@photong @TjeuKayim
@Keats @stanistan
Docs next (#858)
5ba4d47 
* Update installation.md

* Update cli-usage.md

* Update installation.md

* Update directory-structure.md

* Update configuration.md

* Update overview.md

* Update section.md

* Update page.md

* Update section.md

* Update configuration.md

* Update page.md

* Update section.md

* Update page.md

* Update shortcodes.md

* Update linking.md

* Update table-of-contents.md

* Update syntax-highlighting.md

* Update taxonomies.md

* Update search.md

* Update sass.md

* Update index.md

* Update multilingual.md

* Update overview.md

* Update pages-sections.md

* Update pagination.md

* Update taxonomies.md

* Update rss.md

* Update sitemap.md

* Update robots.md

* Update 404.md

* Update archive.md

* Update overview.md

* Update installing-and-using-themes.md

* Update creating-a-theme.md

* Update netlify.md

* Update github-pages.md

* Update gitlab-pages.md

* Updates.

* Skip link checking for URL with prefix in config (#846)

* Fix some doc changes

* Section extra -> SitemapEntry (#850)

* Update deps

* Remove tutorial link.

* Update overview.md

* Update page.md

* Update section.md

* Update netlify.md

* Update overview.md

* Change some wording.

* Update overview.md

Co-authored-by: Tjeu Kayim <[email protected]>
Co-authored-by: Vincent Prouillet <[email protected]>
Co-authored-by: Stan Rozenraukh <[email protected]>
@sgued sgued mentioned this pull request Oct 30, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanistan @Keats