Add path to TranslatedContent
#863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
requested changes
Nov 28, 2019
This makes it possible to retrieve the translated page through the `get_page` function.
phil-opp
force-pushed
the
translations-file-path
branch
from
9488b92 to
9521594
Compare
phil-opp
changed the title
TranslatedContentTranslatedContent
|
Just for sanity check, did you test it locally to ensure it does what you need? I think we could add a call to get_page in https://github.com/getzola/zola/blob/master/test_site_i18n/templates/page.html and check it in the components/sites/tests/i18n files since there is no other easy to test it. |
Use it with the `get_page` function to get a reference to the page object.
|
Yes, I tested it locally.
Done!
No worries! It's definitely a good idea to add a test for this. |
|
Thanks! |
Keats
pushed a commit
that referenced
this pull request
Feb 3, 2020
* Add path to `TranslatedContent` This makes it possible to retrieve the translated page through the `get_page` function. * Use TranslatedContent::path field in test_site_i18n Use it with the `get_page` function to get a reference to the page object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to retrieve the translated page through the
get_pagefunction.Fixes #859