Update tokio and re-enable check_site test #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tokio-rs/tokio#2046 (comment) looks like it can still deadlock? |
samford
force-pushed
the
check-site-test-fix
branch
from
a943db2 to
62c4713
Compare
|
Hmm, it definitely can't hurt to wait a bit longer and see how that issue plays out (i.e., if another related tokio version is released) but this at least seems to be a promising fix for the |
The issue with the check_site test hanging and timing out seems to be related to a similar reqwest issue, which was ultimately due to an upstream bug in tokio and may be fixed in tokio 0.2.7 onward.
samford
force-pushed
the
check-site-test-fix
branch
from
62c4713 to
9d970b3
Compare
|
tokio 0.2.9 has been released and addresses the issue you linked. I updated this PR and tested it locally (upwards of 20 times for this version, probably around 50 times total now) and I still haven't seen the |
|
Very nice, thanks! |
Keats
pushed a commit
that referenced
this pull request
Feb 3, 2020
The issue with the check_site test hanging and timing out seems to be related to a similar reqwest issue, which was ultimately due to an upstream bug in tokio and may be fixed in tokio 0.2.7 onward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the
sitecomponent'scheck_sitetest timing out (#908) seems to be related to a similar reqwest issue with the blocking client (seanmonstar/reqwest#746). This was ultimately due to an upstream bug in tokio and should be fixed in tokio 0.2.7 onward.I've updated the tokio dependency to the latest version (0.2.8) and re-enabled the
check_sitetest. I've run the test a number of times locally and haven't seen it time out, whereas before I would have seen the issue at least once by now.