Update to rails 7 #171
Merged
Update to rails 7 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
commented
Mar 14, 2024
| # Eager loading loads your whole application. When running a single test locally, | ||
| # this probably isn't necessary. It's a good idea to do in a continuous integration | ||
| # system, or in some way before deploying your code. | ||
| config.eager_load = ENV['CI'].present? |
There was a problem hiding this comment.
It seems spring and eager loading lead to code coverage being broken... See simplecov-ruby/simplecov#381
It's not worth the trouble for saving a second of boot time.
rnestler
force-pushed
the
update-to-rails-7
branch
from
e93f2d3 to
ea5fdba
Compare
The changes are due to defaults changing for the datetime precision. See * https://github.com/rails/rails/blob/v7.0.2.3/activerecord/CHANGELOG.md#rails-702-february-08-2022 * https://github.com/rails/rails/pull/42297o * https://stackoverflow.com/questions/71411355/rails-7-0-schema-has-arbitrary-precision-6-added-on-my-timestamps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.