Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added supports_transfer function. #2461

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Added supports_transfer function. #2461

merged 1 commit into from
Nov 12, 2018

Conversation

bbrown683
Copy link
Contributor

@bbrown683 bbrown683 commented Nov 7, 2018 •
edited
Loading

Fixes #issue
PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends:
  • rustfmt run on changed code

This change is Reviewable

zakarumych
zakarumych suggested changes Nov 7, 2018
View reviewed changes
src/hal/src/queue/capability.rs
@@ -50,7 +50,9 @@ impl Capability for Compute {
impl Capability for Transfer {
fn supported_by(qt: QueueType) -> bool {
match qt {
_ => true
QueueType::General |
QueueType::Transfer => true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compute and Graphics queues supports transfer too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow slipped my mind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@bbrown683
Added supports_transfer function.
d6037c9 
Adding supports_transfer function.
kvark
kvark approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
bors r+

bors bot added a commit that referenced this pull request Nov 12, 2018
@bors @bbrown683
Merge #2461
11c4f74 
2461: Added supports_transfer function. r=kvark a=bbrown683

Fixes #issue
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/gfx-rs/gfx/2461)
<!-- Reviewable:end -->


Co-authored-by: Ben Brown <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 12, 2018

Build succeeded

@bors bors bot merged commit d6037c9 into gfx-rs:master Nov 12, 2018
@bbrown683 bbrown683 deleted the transfer_queue branch November 12, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakarumych zakarumych zakarumych requested changes

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbrown683 @kvark @zakarumych