Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

[hlsl-out] Zero initialize variables. Write interpolation and sampling qualifier #1075

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

Gordon-F
Copy link
Collaborator

@Gordon-F Gordon-F commented Jul 6, 2021

No description provided.

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one note here

src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
tests/snapshots.rs Show resolved Hide resolved
@Gordon-F Gordon-F force-pushed the hlsl-out branch 2 times, most recently from ee17069 to 0b5a525 Compare July 6, 2021 20:49
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One small nit :)

src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
@kvark kvark merged commit 9e61390 into gfx-rs:master Jul 7, 2021
@Gordon-F Gordon-F deleted the hlsl-out branch July 7, 2021 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants