Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

[glsl-out] Convert modulo operator on float to SPIR-V OpFRem equivalent function #1452

Merged
merged 1 commit into from
Oct 7, 2021
Merged

[glsl-out] Convert modulo operator on float to SPIR-V OpFRem equivalent function #1452

merged 1 commit into from
Oct 7, 2021

Conversation

Gordon-F
Copy link
Collaborator

@Gordon-F Gordon-F commented Oct 7, 2021

Fix #1451

@JCapucho
Copy link
Collaborator

JCapucho commented Oct 7, 2021

This translation isn't correct see #1410

@kvark kvark requested a review from JCapucho October 7, 2021 12:35
@Gordon-F Gordon-F changed the title Convert modulo operator on float vector to mod function Convert modulo operator on float to SPIR-V OpFRem equivalent function Oct 7, 2021
@Gordon-F Gordon-F changed the title Convert modulo operator on float to SPIR-V OpFRem equivalent function [glsl-out] Convert modulo operator on float to SPIR-V OpFRem equivalent function Oct 7, 2021
kvark
kvark reviewed Oct 7, 2021
View reviewed changes
src/back/glsl/mod.rs Show resolved Hide resolved
src/back/glsl/mod.rs Outdated Show resolved Hide resolved
src/back/glsl/mod.rs Outdated Show resolved Hide resolved
@kvark kvark added this to the Version 0.7 milestone Oct 7, 2021
@kvark kvark merged commit 943235c into gfx-rs:master Oct 7, 2021
@Gordon-F Gordon-F deleted the glsl-out branch October 7, 2021 21:00
@teoxoy teoxoy mentioned this pull request Dec 14, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kvark kvark kvark approved these changes

@JCapucho JCapucho Awaiting requested review from JCapucho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.7
Development

Successfully merging this pull request may close these issues.

[wgsl-in]/[glsl-out] Bug with vec types and modulo operator
3 participants
@Gordon-F @JCapucho @kvark