This repository has been archived by the owner on Jan 29, 2025. It is now read-only.
[spv-in] Cast int comparisons arguments #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Operations like `OpUGreaterThan` accept arguments as long as they are integers (signedness doesn't matter) but they must be interpreted as `Uint`s.
|
Seems like something changed in the float display behavior making it use the scientific notation and clippy has a false positive rust-lang/rust-clippy#7579. How should we proceed about these? |
|
I'm on latest Rust, and I don't see this test error, strangely :/ |
|
This seems to be a nightly only issue, I needed to do cargo +nightly clippy --all-features |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operations like
OpUGreaterThanaccept arguments as long as they are integers(signedness doesn't matter) but they must be interpreted as
Uints.Currently naga doesn't handle this and can cause issues with validation. This PR fixes it by casting them to the appropriate scalar kind.