This repository has been archived by the owner on Jan 29, 2025. It is now read-only.
glsl-out: texture function fixes #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had to also patch spv-out since it suffered the same problem of using lod for |
JCapucho
force-pushed
the
glsl-out-function-fixes
branch
2 times, most recently
from
700da14 to
8fa35be
Compare
kvark
approved these changes
Feb 22, 2022
- samplerCubeShadow requires vec3 gradients - Bias must be written after offset - sampler1D hack on GLES requires vec2 gradients - textureSize doesn't accept a lod argument for MS samplers - sampler1DArray hack on GLES requires a y component on imageLoad
JCapucho
force-pushed
the
glsl-out-function-fixes
branch
from
8fa35be to
92d096f
Compare
|
@kvark thanks for the review, should I take your approval as a merge once fixed? |
|
Yes, that was the idea. If I'm not sure that merge is OK after fixes, I'm not making it "Approved" :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds some tests in wgsl