Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

Handle Unpack2x16float in hlsl #2002

Merged
merged 2 commits into from
Jul 17, 2022
Merged

Handle Unpack2x16float in hlsl #2002

merged 2 commits into from
Jul 17, 2022

Conversation

expenses
Copy link
Contributor

@expenses expenses commented Jul 8, 2022

f16tof32 handles unpacking of the lower half of a uint to a 16-bit float, so we need to call that twice, with a bitshift the second time.

expenses
expenses commented Jul 8, 2022
View reviewed changes
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
cwfitzgerald
cwfitzgerald approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!

@cwfitzgerald cwfitzgerald merged commit cc98539 into gfx-rs:master Jul 17, 2022
@jimblandy jimblandy mentioned this pull request Nov 8, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@expenses @cwfitzgerald