Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

[wgsl-in] Remove non-32bit integers #2146

Merged
merged 4 commits into from
Dec 12, 2022
Merged

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Dec 5, 2022

Validation already fails on any non-32bit integers but this change makes it clearer what the frontend actually supports.

Also commented out f16, we can uncomment it once we implement the extension.

@teoxoy teoxoy changed the title Remove non-32bit integers [wgsl-in] Remove non-32bit integers Dec 5, 2022
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I kind of wish we could just keep all these types in the front end, and reject them in validation. But they're not in the WGSL spec, so that doesn't make sense.

@jimblandy jimblandy merged commit 9a00937 into master Dec 12, 2022
@jimblandy jimblandy deleted the remove-non-32-bit-integers branch December 12, 2022 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants