This repository has been archived by the owner on Jan 29, 2025. It is now read-only.
Fix zero initialization of workgroup memory #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
suggested changes
Feb 20, 2023
use local (not global) invocation id
teoxoy
force-pushed
the
fix-zero-init
branch
from
75338e9 to
bbbc0d7
Compare
jimblandy
approved these changes
Feb 21, 2023
DJMcNab
reviewed
Apr 9, 2024
| @@ -430,7 +430,7 @@ impl Writer { | |||
| constituent_ids.push(id); | |||
|
|
|||
| if binding == &crate::Binding::BuiltIn(crate::BuiltIn::GlobalInvocationId) { | |||
There was a problem hiding this comment.
I'm digging into this again for gfx-rs/wgpu#4592. Why was this one left as Global?
There was a problem hiding this comment.
It seems I missed this one 😅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use local (not global) invocation id - duh 🙄.
Credits go to @nical who found out the issue!