Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

spv-out: implement OpArrayLength on array buffer bindings #2372

Closed
wants to merge 2 commits into from

Conversation

kvark
Copy link
Member

@kvark kvark commented Jun 6, 2023

@jimblandy
Copy link
Member

Rebased to get rid of changes to irrelevant snapshot files

src/back/spv/index.rs Outdated Show resolved Hide resolved
src/back/spv/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the back/spv changes can be simplified; see the earlier comments.

@kvark
Copy link
Member Author

kvark commented Jun 20, 2023

@jimblandy please take a look at the comments, PR is rebased

src/back/spv/index.rs Outdated Show resolved Hide resolved
@kvark
Copy link
Member Author

kvark commented Jun 23, 2023

@jimblandy ready for round 3
Amazing review, as always, and thanks for the insights!

@JMS55
Copy link
Contributor

JMS55 commented Aug 4, 2023

Thanks so much for the work on this! Any chance it can be rebased to naga main?

@cwfitzgerald
Copy link
Member

Hello, thank you for your PR against Naga!

As part of gfx-rs/wgpu#4231, we have moved development of Naga into the wgpu repository in the Naga subfolder. We have transferred all issues, but we are unable to automatically transfer PRs.

As such, please recreate your PR against the wgpu repository. We apologize for the inconvenience this causes, but will make contributing to both projects more streamlined going forward.

We are leaving PRs open, but once they are transferred, please close the original Naga PR.

@kvark
Copy link
Member Author

kvark commented Mar 23, 2024

Ported as gfx-rs/wgpu#5428

@kvark kvark closed this Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spv-out] Cannot use arrayLength() on a runtime-sized array contained within a binding_array
4 participants