Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

[glsl-out] textureSize level must be a signed integer. #2397

Merged
merged 1 commit into from
Jul 4, 2023
Merged

[glsl-out] textureSize level must be a signed integer. #2397

merged 1 commit into from
Jul 4, 2023

Conversation

nical
Copy link
Contributor

@nical nical commented Jul 4, 2023 •
edited
Loading

This fixes shader compilation issues when writing wgsl code like textureDimensions(texture, 0u) with the GLSL backend.
GLSL textureSize spec

teoxoy
teoxoy approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teoxoy teoxoy merged commit 7624d6c into gfx-rs:master Jul 4, 2023
@nical nical deleted the glsl-img-size branch July 4, 2023 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nical @teoxoy