Bump indexmap to v2

[daxpedda]

Bumps indexmap to v2.
See the changelog, I don't believe there are any relevant changes for naga.

Notably this updates hashbrown from v0.12 to v0.14 and ahash from v0.7 to v0.8.

[daxpedda]

So the minimal versions check fails because indexmap v2.0.0 -> arbitrary v1.0.0 -> derive_arbitrary v1.0.0 depends on syn v1.0.0, which it doesn't actually support. It requires at least syn v1.0.6.

derive_arbitrary v1.3.0 doesn't have this issue, as it relies on syn v1.0.56.
arbitrary v1.3.0 would require at least derive_arbitrary v1.3.0, which if indexmap depends on could fix this issue.

So either we:

1. Make a PR to indexmap telling them to bump to arbitrary v1.3.
2. Or we could just add a line in our CI bumping syn to v1.0.6 after generating the minimal lockfile.

Happy to apply either solution.

[ErichDonGubler]

I don't believe there are any blockers on the Firefox side for this upgrade; Mike Hommey had a plan to force-downgrade `indexmap` 2 deps. to v1, since they're source-compatible. I don't know if that plan was executed, but I'm not concerned. CC @jimb.

…

On Tue, Aug 8, 2023 at 6:02 AM daxpedda ***@***.***> wrote: So the minimal versions check fails because indexmap v2.0.0 -> arbitrary v1.0.0 -> derive_arbitrary v1.0.0 depends on syn v1.0.0, which it doesn't actually support. It requires at least syn v1.0.6. derive_arbitrary v1.3.0 doesn't have this issue, as it relies on syn v1.0.56. arbitrary v1.3.0 would require at least derive_arbitrary v1.3.0, which if indexmap depends on could fix this issue. So either we: 1. Make a PR to indexmap telling them to bump to arbitrary v1.3. 2. Or we could just add a line in our CI bumping syn to v1.0.6 after generating the minimal lockfile. Happy to apply either solution. — Reply to this email directly, view it on GitHub <#2426 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFAY2UQ7VNDMZSCSNKJD5DXUITHHANCNFSM6AAAAAA3IK2GGQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[teoxoy]

Looks like it https://searchfox.org/mozilla-central/source/build/rust/indexmap

It's missing feature flags but those shouldn't be too hard to add.

[teoxoy]

@daxpedda

1. Make a PR to indexmap telling them to bump to arbitrary v1.3.

I think this would be preferred.

[fornwall]

Make a PR to indexmap telling them to bump to arbitrary v1.3.

Created indexmap-rs/indexmap#271

[daxpedda]

As noted in indexmap-rs/indexmap#271, this was already broken on our side.
Fixed in #2429.

[teoxoy]

If you rebase, I think we should be able to merge this one now.