This repository has been archived by the owner on Jan 29, 2025. It is now read-only.
[wgsl-in] Handle all(bool) and any(bool) #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fornwall
force-pushed
the
wgsl-any-all-bool
branch
from
68cce7b to
4bd03fd
Compare
teoxoy
reviewed
Aug 29, 2023
teoxoy
approved these changes
Aug 29, 2023
fornwall
force-pushed
the
wgsl-any-all-bool
branch
from
54a71b7 to
ce731cf
Compare
Thanks - applied the suggestion and squashed the commits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In wgsl there are overloads for
all(bool)andany(bool)which just returns the boolean unmodified.As at least glsl any and all does not support that, let's remove them while lowering to get rid of them early.
Fixes #1911.