Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

Disable uniformity analysis for the fragment stage #2515

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Disable uniformity analysis for the fragment stage #2515

merged 2 commits into from
Sep 28, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Sep 26, 2023 •
edited
Loading

Disables uniformity requirements for the following:

  • derivative builtin functions
  • textureSample
  • textureSampleBias
  • textureSampleCompare

These are the same builtins derivative_uniformity diagnostic targets.

This is a temporary change until we get to gfx-rs/wgpu#4369.

@teoxoy teoxoy requested a review from jimblandy September 26, 2023 17:31
jimblandy
jimblandy approved these changes Sep 28, 2023
View reviewed changes
src/valid/analyzer.rs Show resolved Hide resolved
@teoxoy teoxoy merged commit e6a47ba into gfx-rs:master Sep 28, 2023
@teoxoy teoxoy deleted the disable-uniformity-req-on-fragment-stage branch October 3, 2023 15:49
@dneto0 dneto0 mentioned this pull request Jan 21, 2022
Closed
@chenrui333 chenrui333 mentioned this pull request Oct 25, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @jimblandy