Merge #107

107: Fix wgpuQueueWriteTexture signature r=kvark a=almarklein

closes #105 

@devorc like this? Looking at the header:
```h
GPU_EXPORT void wgpuQueueWriteTexture(WGPUQueue queue, WGPUImageCopyTexture const * destination, void const * data, 
    size_t dataSize, WGPUTextureDataLayout const * dataLayout, WGPUExtent3D const * writeSize);
```

I suppose everything `const *` must be either `*const` or `&` in Rust, but how to decide between these?

Co-authored-by: Almar Klein <[email protected]>

src/command.rs

@@ -8,10 +8,10 @@ use wgc::{
 #[no_mangle]
 pub unsafe extern "C" fn wgpuCommandEncoderFinish(
     encoder: id::CommandEncoderId,
-    desc: &native::WGPUCommandBufferDescriptor,
+    descriptor: &native::WGPUCommandBufferDescriptor,
 ) -> id::CommandBufferId {
     let desc = wgt::CommandBufferDescriptor {
-        label: OwnedLabel::new(desc.label).into_cow(),
+        label: OwnedLabel::new(descriptor.label).into_cow(),
     };
 
     check_error(gfx_select!(encoder => GLOBAL.command_encoder_finish(encoder, &desc)))

src/device.rs

@@ -117,17 +117,17 @@ pub unsafe extern "C" fn wgpuDeviceCreateShaderModule(
 #[no_mangle]
 pub extern "C" fn wgpuDeviceCreateBuffer(
     device: id::DeviceId,
-    desc: &native::WGPUBufferDescriptor,
+    descriptor: &native::WGPUBufferDescriptor,
 ) -> id::BufferId {
-    let usage = wgt::BufferUsage::from_bits(desc.usage).expect("Buffer Usage Invalid.");
-    let label = OwnedLabel::new(desc.label);
+    let usage = wgt::BufferUsage::from_bits(descriptor.usage).expect("Buffer Usage Invalid.");
+    let label = OwnedLabel::new(descriptor.label);
     check_error(gfx_select!(device => GLOBAL.device_create_buffer(
         device,
         &wgt::BufferDescriptor {
             label: label.as_cow(),
-            size: desc.size,
+            size: descriptor.size,
             usage,
-            mapped_at_creation: desc.mappedAtCreation,
+            mapped_at_creation: descriptor.mappedAtCreation,
         },
         PhantomData
     )))
@@ -363,9 +363,9 @@ pub unsafe extern "C" fn wgpuDeviceGetQueue(device: id::DeviceId) -> id::QueueId
 pub unsafe extern "C" fn wgpuQueueSubmit(
     queue: id::QueueId,
     command_count: u32,
-    command_buffers: *const id::CommandBufferId,
+    commands: *const id::CommandBufferId,
 ) {
-    let command_buffer_ids = make_slice(command_buffers, command_count as usize);
+    let command_buffer_ids = make_slice(commands, command_count as usize);
     gfx_select!(queue => GLOBAL.queue_submit(queue, command_buffer_ids))
         .expect("Unable to submit queue")
 }
@@ -386,11 +386,11 @@ pub unsafe extern "C" fn wgpuQueueWriteBuffer(
 #[no_mangle]
 pub unsafe extern "C" fn wgpuQueueWriteTexture(
     queue: id::QueueId,
-    destination: native::WGPUImageCopyTexture,
+    destination: &native::WGPUImageCopyTexture,
     data: *const u8, // TODO: Check - this might not follow the header
     data_size: usize,
-    data_layout: native::WGPUTextureDataLayout,
-    write_size: native::WGPUExtent3D,
+    data_layout: &native::WGPUTextureDataLayout,
+    write_size: &native::WGPUExtent3D,
 ) {
     let slice = make_slice(data, data_size);
     gfx_select!(queue => GLOBAL.queue_write_texture(
@@ -573,14 +573,14 @@ pub unsafe extern "C" fn wgpuDeviceCreateRenderPipeline(
 pub extern "C" fn wgpuDeviceCreateSwapChain(
     device: id::DeviceId,
     surface: id::SurfaceId,
-    desc: &native::WGPUSwapChainDescriptor,
+    descriptor: &native::WGPUSwapChainDescriptor,
 ) -> id::SwapChainId {
     let desc = wgt::SwapChainDescriptor {
-        usage: wgt::TextureUsage::from_bits(desc.usage).unwrap(),
-        format: conv::map_texture_format(desc.format).expect("Texture format not defined"),
-        width: desc.width,
-        height: desc.height,
-        present_mode: conv::map_present_mode(desc.presentMode),
+        usage: wgt::TextureUsage::from_bits(descriptor.usage).unwrap(),
+        format: conv::map_texture_format(descriptor.format).expect("Texture format not defined"),
+        width: descriptor.width,
+        height: descriptor.height,
+        present_mode: conv::map_present_mode(descriptor.presentMode),
     };
     let (id, error) =
         gfx_select!(device => GLOBAL.device_create_swap_chain(device, surface, &desc));