This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Fix initializing buffer with unaligned data #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In wgpu 0.7, this was a valid operation, the zero padding was done by hand. However in gfx-rs#872 this was removed as an optimization since buffers are zero padded, however the slice end was taken from buffer.slice which has to be aligned when mapped.
grovesNL
approved these changes
May 7, 2021
|
Build succeeded: |
|
Do you need a patch for this? |
|
That would be great! |
|
It's on crates! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In wgpu 0.7, this was a valid operation, the zero padding was done by hand.
In #872 this logic was removed as an optimization since buffers are already zero initialized, however the slice end was taken from buffer.slice which has to be aligned when mapped.
This is causing issues when trying to update imgui-wgpu-rs (Yatekii/imgui-wgpu-rs#54) to wgpu 0.8 since they use U16 index buffers with odd lengths.