Ensure the BufferMapCallback is always called. #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added this to the changelog because the PR template says so, but I wouldn't be offended if this type of plumbing isn't changelog-worthy! |
|
Hm, I just realized that |
|
I updated the PR to be more principled about invoking the callback outside of the lock in buffer_map_async. |
jimblandy
changed the title
jimblandy
requested changes
Jul 7, 2022
nical
force-pushed
the
map-async-callback
branch
5 times, most recently
from
507fa30 to
6156d97
Compare
jimblandy
approved these changes
Jul 7, 2022
This solves two issues on the Gecko side: - The callback cleans up after itself (the user data is deleted at the end of the callback), so dropping the callback without calling it is a memory leak. I can't think of a better way to implement this on the C++ side since there can be any number of callback at any time living for an unspecified amount of time. - This makes it easier to implement the error reporting of the WebGPU spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
WebGPU specification
Description
This PR enforces that the mapping callback is always called (be it with an error). It does so by calling it manually in more places (with corresponding error codes) and by catching the rest in the callback's destructor.
This solves two issues on the Gecko side:
Note that when the callback is fired by its
Dropimpl, there is no guarantee that it happens outside of the locks. If that's a big issue, we could instead panic in the drop impl and be very careful about the control flow.Also, the WebGPU spec specifies what should happen when destroying a buffer that is mapped or pending. The easiest way to conform to that is to just call unmap. I suspect that it will also avoid issues with wgpu itself?
Testing
None.