Cache MAX_SAMPLES on gles backend #5346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
force-pushed
the
max_sample_cache
branch
from
85ed71e to
eaf0b01
Compare
Wumpf
requested changes
Mar 6, 2024
Dinnerbone
force-pushed
the
max_sample_cache
branch
from
eaf0b01 to
6c2137a
Compare
Wumpf
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Believe it or not, this actually showed a little hot for us when measuring on Firefox webgl. Every call to
get_texture_format_featuresended up with an IPC to fetch the max sample count, which is a static immutable value.Let's cache it on creation and keep things cheap. Also helps avoid a lock, which is always nice.
Testing
All existing tests pass? :D
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.