Make Force Loop Bounding Optional #6662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
cw/remove-kludge
branch
from
211f5de to
05e49de
Compare
DJMcNab
approved these changes
Dec 5, 2024
cwfitzgerald
force-pushed
the
cw/remove-kludge
branch
2 times, most recently
from
8508936 to
22802ff
Compare
Co-authored-by: rudderbucky <[email protected]>
cwfitzgerald
force-pushed
the
cw/remove-kludge
branch
from
22802ff to
f22f7cc
Compare
DJMcNab
approved these changes
Dec 6, 2024
| /// may allow shaders to see wider regions of the buffers than expected, | ||
| /// making such deferred initialization visible to the application. | ||
| pub bounds_checks: bool, | ||
| /// |
There was a problem hiding this comment.
Missing first line of docs here
nical
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of #6520 with a different api.
Depends on #6661, but can be separated if desired.
cc @DJMcNab @jimblandy
Expected Review Experience: Review the last commit.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.