[naga spv-in] Let BlockContext hold a &mut Module.
#6682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
added
naga
Refactor `front::spv::BlockContext` so that, rather than holding various shared and mutable references to various fields of the `crate::Module` being constructed, it holds just a single `&mut Module`, and accesses its fields through that. This should allow the SPIR-V front to use utility functions like `Module::generate_predeclared_type` as intended. Fixes gfx-rs#6679.
jimblandy
force-pushed
the
naga-spv-in-blockcontext-mut-module
branch
from
0eb06f1 to
c8a8bfd
Compare
8 tasks
teoxoy
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
front::spv::BlockContextso that, rather than holding various shared and mutable references to various fields of thecrate::Modulebeing constructed, it holds just a single&mut Module, and accesses its fields through that.This should allow the SPIR-V front to use utility functions like
Module::generate_predeclared_typeas intended.Fixes #6679.