Add directive keywords to error message for parsing global item #6723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-hat
force-pushed
the
6421-add-directive-keywords-to-global-item-parse-message
branch
from
6ca2422 to
40705ca
Compare
ErichDonGubler
requested changes
Dec 16, 2024
ErichDonGubler
added
type: enhancement
ErichDonGubler
approved these changes
Dec 16, 2024
|
Interestingly, the term "item" (from before this PR) is a Naga concept, rather than a standard WGSL one. 🤔 I had hoped to align the vocabulary at the same time as the issue was handled, but I notice that didn't communicate that. I'm happy to save that for a further iteration, or even drop the thought entirely; I don't think it's going to be a problem in practice. |
ErichDonGubler
force-pushed
the
6421-add-directive-keywords-to-global-item-parse-message
branch
from
e05096a to
68ddfd0
Compare
Notify the user that they can also use `diagnostic`, `enable`, or `requires` in this context.
ErichDonGubler
force-pushed
the
6421-add-directive-keywords-to-global-item-parse-message
branch
from
68ddfd0 to
3402f28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify the user that they can also use
diagnostic,enable, orrequiresin this context.Connections
Addresses #6421.
Description
Support for directives has recently improved, so this error message now reflects that the user can also use directive keywords at the top-level.
Testing
Verified locally, did not add a test for this small change in accordance with the style of the tests in this module.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.