Skip to content

Commit

Permalink
split: add gguf-split in the make build target (#6262)
Browse files Browse the repository at this point in the history
  • Loading branch information
phymbert authored Mar 23, 2024
1 parent 1b26aeb commit 21cad01
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Define the default target now so that it is always the first target
BUILD_TARGETS = \
main quantize quantize-stats perplexity imatrix embedding vdot q8dot train-text-from-scratch convert-llama2c-to-ggml \
simple batched batched-bench save-load-state server gguf llama-bench libllava.a llava-cli baby-llama beam-search \
simple batched batched-bench save-load-state server gguf gguf-split llama-bench libllava.a llava-cli baby-llama beam-search \
speculative infill tokenize benchmark-matmult parallel finetune export-lora lookahead lookup passkey gritlm tests/test-c.o

# Binaries only useful for tests
Expand Down

4 comments on commit 21cad01

@ggerganov
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that CI / macOS-latest-cmake-x64 started failing - there have been no related changes here

https://github.com/ggerganov/llama.cpp/actions/runs/8403021607/job/23013069171

@phymbert
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why adding a build target in the make toolchain has an impact on ctest for metal backend tensor allocation :/ @slaren @ngxson ?

20: ggml_metal_free: deallocating
20: failed to allocate tensors [Metal] 1377/1601 tests passed
20: Backend Metal: FAIL
20:
20: 1/2 backends passed
20: FAIL
20/22 Test #20: test-backend-ops ....................***Failed 0.21 sec
test 21

@ggerganov
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work again on the latest build, so probably not important

@ggerganov
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.