-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault in grammar #4066
Comments
wow so rule 9 is jusT null
i am going to add a check |
Now looking at it, |
ran the debugger, rule 9 was never added.
|
so it is a whole created by resize that is used and crashes, i am going to try and find what causes the id 9 to be dropped |
I added my debug code to the branch |
Looking at the new debug dump:
|
I was able to resolve the bug, it seems to be the - in the rule. a05aa8a so this caused the crash |
ran into the same issue. Does a05aa8a fix the segfault? |
So, this code does not fix the segfault but lets you diagnose the issue,
I have not fixed the root cause of the crash, which was for me the "-" char
that i had to remove, but it showed the holes. the issue is that some rules
are not being parsed and they create holes in the grammar that crash. I was
not able to get it to work around them either. my plan is to use antlr4
grammar parser in C++ later for llama.cpp if I can then we can use antlr to
check the grammars and generate the checkers, but this will need more work.
…On Thu, Nov 16, 2023, 09:45 tadad ***@***.***> wrote:
ran into the same issue. Does a05aa8a
<a05aa8a>
fix the segfault?
—
Reply to this email directly, view it on GitHub
<#4066 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5KQ2LHSODASWNVB2T7W63YEYRKBAVCNFSM6AAAAAA7JY2BA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJUGU4DSNRSGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
seems related to #3878 |
This issue was closed because it has been inactive for 14 days since being marked as stale. |
Prerequisites
Expected Behavior
see ebnf.ebnf in pr master...meta-introspector:llama.cpp:bugreport/ebnf#diff-8fbce6bdd71d2aae9d1f7fc3012fd793035a6d35b970544d46aa161844ef97e2
Current Behavior
The text was updated successfully, but these errors were encountered: