Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama : remove notion of CLS token #11064

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ggerganov
Copy link
Owner

target #11062

My understanding is that there is no need to distinguish between BOS and CLS tokens, so we can simplify the implementation logic by removing CLS.

@github-actions github-actions bot added the python python script changes label Jan 3, 2025
Copy link
Collaborator

@danbev danbev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is only about the CLS token itself, which is not used in decoders hence only the BOS is needed, and has nothing to do with the pooling type CLS right?

Base automatically changed from gg/llama-refactor-3 to master January 6, 2025 08:52
@ggerganov ggerganov requested a review from ngxson as a code owner January 6, 2025 08:52
@ggerganov
Copy link
Owner Author

So this is only about the CLS token itself, which is not used in decoders hence only the BOS is needed, and has nothing to do with the pooling type CLS right?

Yes, this is not related to the pooling types. We haven't used the CLS token in any of the examples yet, so I think this is a safe change.

@ggerganov ggerganov force-pushed the gg/llama-refactor-5 branch from a5942f0 to 747c85d Compare January 6, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python python script changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants