fix: Vulkan shader gen binary path when Cross-compiling #11096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Vulkan
|
There's already an open PR for cross compiling fixes (#10448), which has been taking a while (@sparkleholic @bandoti). Are the changes related or is this a separate fix? |
This is a fix for #11037 |
|
These are two separate issues. In the case of #11037 they seem to have some super project which includes Llama.cpp as a submodule from another CMakeList.txt. @sparkleholic has a fix for cross compiling for example using Linux on x86_64 with a build target of aarch64. In this case, it ensure the shaders are generated using the build system architecture. |
0cc4m
reviewed
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-compiling uses the host system's tools，hard-coded paths won't work.