Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama : functions -> methods #11110

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

llama : functions -> methods #11110

wants to merge 8 commits into from

Conversation

ggerganov
Copy link
Owner

  • llama_model

@ggerganov ggerganov force-pushed the gg/llama-refactor-7 branch 2 times, most recently from 3295841 to 287e8c2 Compare January 7, 2025 13:05
@ggerganov ggerganov force-pushed the gg/llama-refactor-7 branch from 287e8c2 to 4d27597 Compare January 7, 2025 13:14
@ggerganov
Copy link
Owner Author

I'm stumped by this error in the CI:

https://github.com/ggerganov/llama.cpp/actions/runs/12654124026/job/35261257507?pr=11110#step:8:355

Not sure what is causing it. @slaren Do you have any guess what could be the issue?

@slaren
Copy link
Collaborator

slaren commented Jan 7, 2025

Looks like a compiler bug, but I cannot reproduce it locally.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Jan 7, 2025
@slaren
Copy link
Collaborator

slaren commented Jan 7, 2025

I think it's safe to assume that this is a compiler bug. It only happens with clang on Windows, and only on release builds. Changing the generator from "ninja multi-config" to "ninja" fixes it for the arm build, but not with hip or sycl. The destructors that it complains about seem to be the maps in llama_vocab, it may be some failure trying while trying to inline the calls.

@ggerganov
Copy link
Owner Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants