Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GL_KHR_cooperative_matrix Vulkan extension if not available. #11117

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

mbaudier
Copy link
Contributor

@mbaudier mbaudier commented Jan 7, 2025

Allows to support Vulkan on platforms where the GL_KHR_cooperative_matrix extension is not available, such as Debian 12/bookworm.

Resolves #11052.

@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Jan 7, 2025
@0cc4m 0cc4m self-requested a review January 7, 2025 06:22
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it's fine on systems with versions new enough to support the extension.

The code looks good, I only have two minor comments. Once those are addressed I'll merge it. Thank you for the contribution!

ggml/src/ggml-vulkan/CMakeLists.txt Outdated Show resolved Hide resolved
ggml/src/ggml-vulkan/ggml-vulkan.cpp Outdated Show resolved Hide resolved
@jeffbolznv
Copy link
Collaborator

LGTM. Yet another reason we should consider building glslc from a known good commit.

@0cc4m 0cc4m merged commit 02f0430 into ggerganov:master Jan 8, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile bug: Vulkan shaders not compiling any more on Debian Stable (12/bookworm)
3 participants