SYCL: Refactor ggml_sycl_compute_forward #11121
Open
+195
−205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally thought I wouldn't do this, but the original code is quite restrictive imo. It assumes that all operations need only src0, src1 and dst tensors, which isn't the case for every OP(also, why are we passing them separately?). This change will allow easy addition of tensor operations to the backend as the
dst
tensor itself contains everything needed to perform the operation. I haven't changed the kernels except for a few function signature changes, as that's outside the scope of this refactoring. Those can be refactored later if needed.