-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix: add cuda to the flake #3202
Conversation
@Tungsten842 pls review :) |
Ok, so for some reason, this is giving me wrong results. only |
My intuition is that you're building the package for the wrong CUDA arch. The |
You where right, since Nix aims to be highly reproducible, flags, such as I might just use the hacky |
I don't know how Nix packages work but if they distribute precompiled packages the problem is rather that on the machine on which the package is compiled there is no GPU so it compiles for the lowest possible compute capability only. If you compile with |
afaik, the build input (nix closure?) is hashed, and that hash can then be looked up on a cache server, if there is a prebuilt binary, it will pull that. disclaimer: i just stared nix(os) a week ago, as a result of my ubuntu install dying, so i might be misinformed :) Part of the "same input, same output" / reproducibility workflow is making compilers platform independent.
yea, i hacked it by replacing |
7aa42f7
to
b86c4bd
Compare
b86c4bd
to
43600f4
Compare
43600f4
to
9d4365d
Compare
The one time I ever tried NixOS, I ran into NixOS/nixpkgs#38635 and gave up, so I wouldn't easily be able to review this. |
Oh damn. Well, you don't need to use nix-env for this. Also, must have been a light system. also, looks like I will be the resident nix reviewer in the future... |
…example * 'master' of github.com:ggerganov/llama.cpp: convert : remove bug in convert.py permute function (ggerganov#3364) make-ggml.py : compatibility with more models and GGUF (ggerganov#3290) gguf : fix a few general keys (ggerganov#3341) metal : reusing llama.cpp logging (ggerganov#3152) build : add ACCELERATE_NEW_LAPACK to fix warning on macOS Sonoma (ggerganov#3342) readme : add some recent perplexity and bpw measurements to READMES, link for k-quants (ggerganov#3340) cmake : fix build-info.h on MSVC (ggerganov#3309) docs: Fix typo CLBlast_DIR var. (ggerganov#3330) nix : add cuda, use a symlinked toolkit for cmake (ggerganov#3202)
this is very much a makeshift solution, but works.This is like other cmake based nix pkgs.
waitingwill open another pr when NixOS/nixpkgs#224291 gets resolved. (hopefully this year)Build
example run: