nix : remove OpenCL remnants #8235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
nix
SomeoneSerge
reviewed
Jul 1, 2024
.devops/nix/package.nix
Outdated
| @@ -281,7 +274,7 @@ effectiveStdenv.mkDerivation ( | |||
| # Configurations we don't want even the CI to evaluate. Results in the | |||
| # "unsupported platform" messages. This is mostly a no-op, because | |||
| # cudaPackages would've refused to evaluate anyway. | |||
| badPlatforms = optionals (useCuda || useOpenCL) lib.platforms.darwin; | |||
| badPlatforms = optionals (useCuda) lib.platforms.darwin; | |||
There was a problem hiding this comment.
Parentheses are now redundant
SomeoneSerge
approved these changes
Jul 1, 2024
MagnusS0
pushed a commit
to MagnusS0/llama.cpp-normistral-tokenizer
that referenced
this pull request
Jul 1, 2024
* nix : remove OpenCL remnants * minor : remove parentheses
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 2, 2024
* nix : remove OpenCL remnants * minor : remove parentheses
okias
added a commit
to okias/llama.cpp
that referenced
this pull request
Aug 11, 2024
Manually adjusted. This reverts commit 554c247. This reverts commit 257f8e4. Signed-off-by: David Heidelberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for OpenCL was removed recently (#7735)