-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Fix build on Windows when ccache enabled (#9954) #9976
base: master
Are you sure you want to change the base?
Conversation
shou692199
commented
Oct 21, 2024
- I have read the contributing guidelines
- Self-reported review complexity:
- Low
- Medium
- High
@shou692199 |
About 5 sec on my 16C32T computer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this change. This seems to reduce the cache hit on Unix. Just compiling llama-bench
on the main branch I get:
$ ccache -s
Cacheable calls: 192 / 288 (66.67%)
Hits: 144 / 192 (75.00%)
Direct: 144 / 144 (100.0%)
Preprocessed: 0 / 144 ( 0.00%)
Misses: 48 / 192 (25.00%)
Uncacheable calls: 96 / 288 (33.33%)
Local storage:
Cache size (GB): 0.0 / 30.0 ( 0.01%)
Hits: 144 / 192 (75.00%)
Misses: 48 / 192 (25.00%)
but with this patch this falls to 50%:
$ ccache -s
Cacheable calls: 96 / 144 (66.67%)
Hits: 48 / 96 (50.00%)
Direct: 48 / 48 (100.0%)
Preprocessed: 0 / 48 ( 0.00%)
Misses: 48 / 96 (50.00%)
Uncacheable calls: 48 / 144 (33.33%)
Local storage:
Cache size (GB): 0.0 / 30.0 ( 0.01%)
Hits: 48 / 96 (50.00%)
Misses: 48 / 96 (50.00%)
It is curious that this compiler_type is not needed on Unix. Maybe it is safer to only set it for Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm not sure what is the impact of setting icl
as the compiler type but it should be fine. I'm happy if @NeoZhangJianyu also is.