Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgraph->work == NULL eventually causes null pointer crash in ggml.c #344

Closed
RndyP opened this issue Dec 29, 2022 · 3 comments
Closed

cgraph->work == NULL eventually causes null pointer crash in ggml.c #344

RndyP opened this issue Dec 29, 2022 · 3 comments

Comments

@RndyP
Copy link

RndyP commented Dec 29, 2022

The eventual crash occurs here:
dst_data is NULL because params->wdata is NULL

image

Cause is way up the stack where cgraph->work is zero:

image

This check is interesting:
image

My environment is Visual Studio 2022. Crash occurs with optimizations on or disabled.
Crash occurs fairly repeatably by simply streaming room noise in whisper.
I can debug somewhat with Visual Studio when I turn off optimizations, although I have no idea what exactly the code is doing.
Let me know if you have any questions or need help. I am hoping if you look at these sections you will have an epiphany.

@RndyP
Copy link
Author

RndyP commented Dec 29, 2022

Hmm, I got the latest version of ggml.c a couple of hours ago, and it seems this issue is fixed. I will close this tomorrow after a few more hours of testing.

@RndyP RndyP closed this as completed Dec 30, 2022
@RndyP RndyP reopened this Dec 30, 2022
@RndyP
Copy link
Author

RndyP commented Dec 30, 2022

Problem is back now. I thought the latest version fixed this, but apparently not. I set audio_ctx to 1536, and now it's back.

@ggerganov
Copy link
Owner

The audio_ctx cannot be larger than 1500. Added checks to prevent that in the future

rock3125 pushed a commit to rock3125/whisper.cpp that referenced this issue Feb 21, 2023
anandijain pushed a commit to anandijain/whisper.cpp that referenced this issue Apr 28, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this issue Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants