fix: use vm_allocate
instead of posix_memalign
for Metal on macOS
#7078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a context in an Electron app using
node-llama-cpp
crashes the process with some models (issue), so I've investigated what's happening and found that allocating a large memory block usingposix_memalign
is the culprit.For some reason, it happens only on Electron and not on Nodejs, but I couldn't figure out why.
From my testings in Electron:
posix_memalign((void **) &data, 16384, 587218944)
- works fineposix_memalign((void **) &data, 16384, 1073741824)
- crashes the process with SIGTRAPI tried switching from
posix_memalign
tomalloc
inggml-metal.m
, and it seems that everything still works correctly, but maybe I'm missing something.I assume that
posix_memalign
is used there for a reason, but since it seems to me that everything still works great withmalloc
, maybe the original reason for usingposix_memalign
is irrelevant by now?I'm not sure whether the change I made in this PR is a good idea, so I opened it so someone more knowledgable in this area can take a look.
This may be a bug specific to Electron, so I shared my findings on the Electron repo, but since I haven't noticed any side effect of this workaround in
llama.cpp
, I think it may be a good idea to also solve this issue here.