Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sampling : add XTC sampler #9742
sampling : add XTC sampler #9742
Changes from all commits
89640b0
9455194
db54ac5
41e1665
d9c9203
f2a2a61
4f8e55b
6d94ba2
49cd211
899e073
74f657c
59e8e63
63e60de
094caea
39940e5
4c44e3d
dbe9ef7
98b204c
8110f78
81a0c26
09bc6d5
c19fb26
6feb6b3
d0b1053
ed535bb
37e02e3
ba29d31
2107882
f7a383f
72db625
882a603
3968369
acada1a
dfe587a
9c43a01
68557eb
ea85a51
cca842f
ea62e65
44bbd63
a3e6522
dfef2c4
436a991
3613a6d
17ad143
2be814a
28d2cff
3496f58
050eb7a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may potentially break 3rd party code that expects this pointer to be unchanged (eg. to free it after sampling). I don't think this is necessarily a problem, but we should make it clear that this pointer may be changed by the samplers, and applications should not rely on it being unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK this is necessary to properly reset seed and maintain repeatability, as recommended by @slaren earlier.