Add support for libpcre2 (compiles and works) #1035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional support to build with libpcre2. Enable by passing --with-pcre2 to ./configure, the default is still to build against legacy libpcre. To facilitate compiling against either PCRE API version, an ag_pcre wrapper API was created. This is done through a combination of AG_PCRE_* defines and ag_pcre_* functions, plus typedefs ag_pcre_re_t and ag_pcre_extra_t At this point, ag can be built with libpcre or libpcre2 and passes tests without modifying them. Preliminary testing hasn't shown much change in speed, but further profiling should still be done.
|
this is great, I cherry picked your changes and updates for the latest code in git. Hopefully with this patch it solves #975 |
|
out of date PR which got no attention anyway |
gcflymoto
added a commit
to gcflymoto/the_silver_searcher
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a thing.
Add optional support to build with libpcre2.
Enable by passing --with-pcre2 to ./configure, the default is still to
build against legacy libpcre.
To facilitate compiling against either PCRE API version, an ag_pcre
wrapper API was created. This is done through a combination of AG_PCRE_*
defines and ag_pcre_* functions, plus typedefs ag_pcre_re_t and
ag_pcre_extra_t
At this point, ag can be built with libpcre or libpcre2 and passes tests
without modifying them. Preliminary testing hasn't shown much change in
speed, but further profiling should still be done.