Adds major version 10 featuring WASM #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh123man
reviewed
Dec 12, 2022
README.md
Outdated
| ## Usage | ||
|
|
||
| ### Feature Support | ||
|
|
||
| | | V5 | V10 | |
There was a problem hiding this comment.
I think V5 and V10 are flipped here as V5 is the CGO variant and supports Kind?
There was a problem hiding this comment.
Definitely, good catch.
gh123man
reviewed
Dec 12, 2022
README.md
Outdated
| | Secrets | ❌ | ❌ | | ||
| | Metadata | ❌ | ❌ | | ||
| | Timezones | ❌ | ❌ | | ||
| | Requires CGO | ❌ | ✅ | |
There was a problem hiding this comment.
too big to fit in this table - but IIRC, the WASM version has a limited exposure to the VRL std lib right (some functions dont work)? May be worth a note.
There was a problem hiding this comment.
yes, good call, added.
gh123man
reviewed
Dec 12, 2022
| | Timezones | ❌ | ❌ | | ||
| | Requires CGO | ❌ | ✅ | | ||
|
|
||
| \* "Basic" API currently means: |
gh123man
reviewed
Dec 12, 2022
| "github.com/tetratelabs/wazero/imports/wasi_snapshot_preview1" | ||
| ) | ||
|
|
||
| //go:embed target/wasm32-wasi/release/vrl_bridge.wasm |
gh123man
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors all existing code into v5 (FFI) and adds a new v10 (WASM).
Currently this also does not add the pre-built wasm binary blobs, that will be done as part of #1
This has a few minor cleanup TODOs left, and a few VRL features left to support to reach parity with V5 in terms of features.