Drop listProps #41
Merged
Drop listProps #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this is indeed a leftover from either the 7.10 or 8 upgrade and we've done something similar and haven't run into any issues. |
|
Thanks for the PR. I moved it to |
|
I forgot to remove it (I believe I wanted to check if it wasn't needed anymore), and used the same name for the replacement, which works slightly differently: constructing the list directly in JS, through the |
|
thanks @luite for merging this! can the issues be closed, then? |
This was referenced Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listPropsis defined in shims, and again in"ghcjs-base" Javascript.Object.Internal.This PR deletes the one in shims. Was it used anywhere?
Related issues:
ghcjs/ghcjs#556
ghcjs/ghcjs#572
ghcjs/ghcjs-base#70