Core refactoring #92
Merged
Core refactoring #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mephenor
force-pushed
the
reactoring_continue_GSI-245
branch
from
386ef43 to
cdb0d2a
Compare
Pull Request Test Coverage Report for Build 7626113286
💛 - Coveralls |
Cito
previously approved these changes
Jan 22, 2024
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this one is quite big as most of the core files have been touched in some way. However, there is not too much new code, as most changes are introduced by grouping/extracting functionality into dedicated modules and classes.
What changed
The focus of this PR is to disentagle the interdependencies that have been introduced into the connector due to organic growth. Functionality pertaining to the 3 commands exposed in the CLI has been moved into dedicated subpackages and the monolithic download/upload modules have been split into multiple, smaller modules dealing with specific aspects of the download/upload process. Where possible and sensible, functionality was grouped into classes and respective abstract base classes were introduced. This was done to remove access to class attributes of upstream classes by classes further down the line, hopefully making the the connector less rigid and brittle. I was trying to maintain some symmetry between the modules in the upload and download package, but this was not always possible, so there might be some stuff in here that would benefit from renaming. More general functionality and functions accessed across the subpackages still remain in core.
Additionally, dependencies have been updated and the local s3_fixture and associated tests have been adjusted to be session scoped and reuse the localstack testcontainer.
The subpackages down-/uploading are called so due to conflicts in monkeypatching as downlod/upload are already taken by function names in the same scope.