Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template and dependencies are updated #97

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Conversation

dontseyit
Copy link
Member

@dontseyit dontseyit commented Jun 6, 2024

This PR updates the repo to Python 3.12 as well as the latest template and dependencies.

I forgot to commit version bump separately, but it's there, done in first commit.

@dontseyit dontseyit requested a review from mephenor June 6, 2024 10:30
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9399362358

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 73.02%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ghga_connector/core/exceptions.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/ghga_connector/core/main.py 2 62.67%
Totals Coverage Status
Change from base Build 8421174418: -0.2%
Covered Lines: 1042
Relevant Lines: 1427

💛 - Coveralls

@dontseyit dontseyit requested a review from TheByronHimes June 6, 2024 11:02
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only saw one thing, rest looks good

tests/fixtures/mock_api/app.py Outdated Show resolved Hide resolved
@mephenor
Copy link
Member

mephenor commented Jun 10, 2024

Quick question: What's the current state of what Python versions we want to limit our user facing tools and libraries to?
I seem to remember we wanted 3.12 for all services, but 3.9 or 3.10 for the rest, but it's been quite a while and I don't think we ever formally decided.

@dontseyit dontseyit requested a review from TheByronHimes June 10, 2024 08:35
@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9444904172

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 73.02%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ghga_connector/core/exceptions.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/ghga_connector/core/main.py 2 62.67%
Totals Coverage Status
Change from base Build 8421174418: -0.2%
Covered Lines: 1042
Relevant Lines: 1427

💛 - Coveralls

@dontseyit
Copy link
Member Author

dontseyit commented Jun 10, 2024

@mephenor Like you said we haven't formally decided this yet but I've updated the CLI tools to 3.12 in order to be able to install them in the same environment. I believe our goal can be update everything to 3.12.

@dontseyit dontseyit merged commit 74550e6 into main Jun 10, 2024
8 checks passed
@dontseyit dontseyit deleted the feature/update-template branch June 10, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants